database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-08 07:21:33 +03:00
Code

Consistently truncate non-key suffix columns.

Browse Source 
INCLUDE indexes failed to have their non-key attributes physically
truncated away in certain rare cases.  This led to physically larger
pivot tuples that contained useless non-key attribute values.  The
impact on users should be negligible, but this is still clearly a
regression (Postgres 11 supports INCLUDE indexes, and yet was not
affected).

The bug appeared in commit dd299df8, which introduced "true" suffix
truncation of key attributes.

Discussion: https://postgr.es/m/CAH2-Wz=E8pkV9ivRSFHtv812H5ckf8s1-yhx61_WrJbKccGcrQ@mail.gmail.com
Backpatch: 12-, where "true" suffix truncation was introduced.
This commit is contained in:
Peter Geoghegan 2020-03-30 12:03:59 -07:00
parent 911e702077
commit 4b42a89938
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/access/nbtree/nbtutils.c
View File

@ -2205,7 +2205,8 @@ _bt_truncate(Relation rel, IndexTuple lastleft, IndexTuple firstright,
{ {
IndexTuple tidpivot; IndexTuple tidpivot;
pivot = index_truncate_tuple(itupdesc, firstright, keepnatts); pivot = index_truncate_tuple(itupdesc, firstright,
Min(keepnatts, nkeyatts));
if (BTreeTupleIsPosting(pivot)) if (BTreeTupleIsPosting(pivot))
{ {
@ -2250,6 +2251,10 @@ _bt_truncate(Relation rel, IndexTuple lastleft, IndexTuple firstright,
/* /*
* No truncation was possible, since key attributes are all equal. * No truncation was possible, since key attributes are all equal.
* It's necessary to add a heap TID attribute to the new pivot tuple. * It's necessary to add a heap TID attribute to the new pivot tuple.
*
* This path is only taken when rel is not an INCLUDE index. It
* avoids a second palloc0() by avoiding the index_truncate_tuple()
* call completely.
*/ */
Assert(natts == nkeyatts); Assert(natts == nkeyatts);
newsize = IndexTupleSize(firstright) + MAXALIGN(sizeof(ItemPointerData)); newsize = IndexTupleSize(firstright) + MAXALIGN(sizeof(ItemPointerData));