mirror of
https://github.com/postgres/postgres.git
synced 2025-09-02 04:21:28 +03:00
Produce a more useful error message for over-length Unix socket paths.
The length of a socket path name is constrained by the size of struct sockaddr_un, and there's not a lot we can do about it since that is a kernel API. However, it would be a good thing if we produced an intelligible error message when the user specifies a socket path that's too long --- and getaddrinfo's standard API is too impoverished to do this in the natural way. So insert explicit tests at the places where we construct a socket path name. Now you'll get an error that makes sense and even tells you what the limit is, rather than something generic like "Non-recoverable failure in name resolution". Per trouble report from Jeremy Drake and a fix idea from Andrew Dunstan.
This commit is contained in:
@@ -73,6 +73,19 @@ typedef struct
|
||||
DEFAULT_PGSOCKET_DIR, \
|
||||
(port))
|
||||
|
||||
/*
|
||||
* The maximum workable length of a socket path is what will fit into
|
||||
* struct sockaddr_un. This is usually only 100 or so bytes :-(.
|
||||
*
|
||||
* For consistency, always pass a MAXPGPATH-sized buffer to UNIXSOCK_PATH(),
|
||||
* then complain if the resulting string is >= UNIXSOCK_PATH_BUFLEN bytes.
|
||||
* (Because the standard API for getaddrinfo doesn't allow it to complain in
|
||||
* a useful way when the socket pathname is too long, we have to test for
|
||||
* this explicitly, instead of just letting the subroutine return an error.)
|
||||
*/
|
||||
#define UNIXSOCK_PATH_BUFLEN sizeof(((struct sockaddr_un *) NULL)->sun_path)
|
||||
|
||||
|
||||
/*
|
||||
* These manipulate the frontend/backend protocol version number.
|
||||
*
|
||||
|
Reference in New Issue
Block a user