database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-12 16:21:30 +03:00
Code

Flush relcache entries when their FKs are meddled with

Browse Source 
Back in commit 100340e2dcd0, we made relcache entries keep lists of the
foreign keys applying to the relation -- but we forgot to update
CacheInvalidateHeapTuple to flush those entries when new FKs got created
or existing ones updated/deleted.  No bugs appear to have been reported
that would be explained by this ommission, but I noticed the problem
while working on an unrelated bugfix which clearly showed it.  Fix by
adding relcache flush on relevant foreign key changes.

Backpatch to 9.6, like the aforementioned commit.

Discussion: https://postgr.es/m/201901211927.7mmhschxlejh@alvherre.pgsql
Reviewed-by: Tom Lane
This commit is contained in:
Alvaro Herrera 2019-01-21 19:34:11 -03:00
parent 058e2757b9
commit 4aead13a75
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/utils/cache/inval.c vendored
View File

@ -53,7 +53,7 @@
* *
* Also, whenever we see an operation on a pg_class or pg_attribute tuple, * Also, whenever we see an operation on a pg_class or pg_attribute tuple,
* we register a relcache flush operation for the relation described by that * we register a relcache flush operation for the relation described by that
* tuple. * tuple. Likewise for pg_constraint tuples for foreign keys on relations.
* *
* We keep the relcache flush requests in lists separate from the catcache * We keep the relcache flush requests in lists separate from the catcache
* tuple flush requests. This allows us to issue all the pending catcache * tuple flush requests. This allows us to issue all the pending catcache
@ -98,6 +98,7 @@
#include "access/htup_details.h" #include "access/htup_details.h"
#include "access/xact.h" #include "access/xact.h"
#include "catalog/catalog.h" #include "catalog/catalog.h"
#include "catalog/pg_constraint.h"
#include "miscadmin.h" #include "miscadmin.h"
#include "storage/sinval.h" #include "storage/sinval.h"
#include "storage/smgr.h" #include "storage/smgr.h"
@ -1193,6 +1194,23 @@ CacheInvalidateHeapTuple(Relation relation,
relationId = indextup->indexrelid; relationId = indextup->indexrelid;
databaseId = MyDatabaseId; databaseId = MyDatabaseId;
} }
else if (tupleRelId == ConstraintRelationId)
{
Form_pg_constraint constrtup = (Form_pg_constraint) GETSTRUCT(tuple);
/*
* Foreign keys are part of relcache entries, too, so send out an
* inval for the table that the FK applies to.
*/
if (constrtup->contype == CONSTRAINT_FOREIGN &&
OidIsValid(constrtup->conrelid))
{
relationId = constrtup->conrelid;
databaseId = MyDatabaseId;
}
else
return;
}
else else
return; return;