database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-23 14:01:44 +03:00
Code Activity

Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c

Browse Source 
6f6f284 has introduced a specific macro to make printf()-ing of LSNs
easier.  This takes care of what looks like the remaining code paths
that did not get the call.

Author: Michael Paquier
Reviewed-by: Kyotaro Horiguchi, Tom Lane
Discussion: https://postgr.es/m/YIJS9x6K8ruizN7j@paquier.xyz
This commit is contained in:
Michael Paquier
2021-04-24 09:09:02 +09:00
parent bb3ecc8c96
commit 4aba61b870
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/access/transam/xlogreader.c
View File

@ -754,8 +754,7 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
targetRecOff == pageHeaderSize) targetRecOff == pageHeaderSize)
{ {
report_invalid_record(state, "contrecord is requested by %X/%X", report_invalid_record(state, "contrecord is requested by %X/%X",
(uint32) (state->DecodeRecPtr >> 32), LSN_FORMAT_ARGS(state->DecodeRecPtr));
(uint32) state->DecodeRecPtr);
goto err; goto err;
} }
@ -968,10 +967,8 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
report_invalid_record( report_invalid_record(
state, state,
"there is no contrecord flag at %X/%X reading %X/%X", "there is no contrecord flag at %X/%X reading %X/%X",
(uint32) (state->recordContRecPtr >> 32), LSN_FORMAT_ARGS(state->recordContRecPtr),
(uint32) state->recordContRecPtr, LSN_FORMAT_ARGS(state->DecodeRecPtr));
(uint32) (state->DecodeRecPtr >> 32),
(uint32) state->DecodeRecPtr);
goto err; goto err;
} }
@ -986,10 +983,8 @@ XLogDecodeOneRecord(XLogReaderState *state, bool allow_oversized)
state, state,
"invalid contrecord length %u at %X/%X reading %X/%X, expected %u", "invalid contrecord length %u at %X/%X reading %X/%X, expected %u",
pageHeader->xlp_rem_len, pageHeader->xlp_rem_len,
(uint32) (state->recordContRecPtr >> 32), LSN_FORMAT_ARGS(state->recordContRecPtr),
(uint32) state->recordContRecPtr, LSN_FORMAT_ARGS(state->DecodeRecPtr),
(uint32) (state->DecodeRecPtr >> 32),
(uint32) state->DecodeRecPtr,
state->recordRemainLen); state->recordRemainLen);
goto err; goto err;
} }