database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Fix some more cases of missed GENERATED-column updates.

Browse Source 
If UPDATE is forced to retry after an EvalPlanQual check, it neglected
to repeat GENERATED-column computations, even though those might well
have changed since we're dealing with a different tuple than before.
Fixing this is mostly a matter of looping back a bit further when
we retry.  In v15 and HEAD that's most easily done by altering the API
of ExecUpdateAct so that it includes computing GENERATED expressions.

Also, if an UPDATE in a partitioned table turns into a cross-partition
INSERT operation, we failed to recompute GENERATED columns.  That's a
bug since 8bf6ec3ba allowed partitions to have different generation
expressions; although it seems to have no ill effects before that.
Fixing this is messier because we can now have situations where the same
query needs both the UPDATE-aligned set of GENERATED columns and the
INSERT-aligned set, and it's unclear which set will be generated first
(else we could hack things by forcing the INSERT-aligned set to be
generated, which is indeed how fe9e658f4 made it work for MERGE).
The best fix seems to be to build and store separate sets of expressions
for the INSERT and UPDATE cases.  That would create ABI issues in the
back branches, but so far it seems we can leave this alone in the back
branches.

Per bug #17823 from Hisahiro Kauchi.  The first part of this affects all
branches back to v12 where GENERATED columns were added.

Discussion: https://postgr.es/m/17823-b64909cf7d63de84@postgresql.org
This commit is contained in:
Tom Lane
2023-03-06 18:31:16 -05:00
parent a0f55fc86a
commit 4a94cbd02b
6 changed files with 210 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/backend/executor/nodeModifyTable.c
View File

@ -1276,6 +1276,15 @@ ExecUpdate(ModifyTableState *mtstate,
bool partition_constraint_failed;
bool update_indexes;
/*
* If we generate a new candidate tuple after EvalPlanQual testing, we
* must loop back here to try again. (We don't need to redo triggers,
* however. If there are any BEFORE triggers then trigger.c will have
* done table_tuple_lock to lock the correct tuple, so there's no need
* to do them again.)
*/
lreplace:
/*
* Constraints and GENERATED expressions might reference the tableoid
* column, so (re-)initialize tts_tableOid before evaluating them.
@ -1289,17 +1298,6 @@ ExecUpdate(ModifyTableState *mtstate,
resultRelationDesc->rd_att->constr->has_generated_stored)
ExecComputeStoredGenerated(estate, slot, CMD_UPDATE);
/*
* Check any RLS UPDATE WITH CHECK policies
*
* If we generate a new candidate tuple after EvalPlanQual testing, we
* must loop back here and recheck any RLS policies and constraints.
* (We don't need to redo triggers, however. If there are any BEFORE
* triggers then trigger.c will have done table_tuple_lock to lock the
* correct tuple, so there's no need to do them again.)
*/
lreplace:;
/* ensure slot is independent, consider e.g. EPQ */
ExecMaterializeSlot(slot);
@ -1314,6 +1312,7 @@ lreplace:;
resultRelInfo->ri_PartitionCheck &&
!ExecPartitionCheck(resultRelInfo, slot, estate, false);
/* Check any RLS UPDATE WITH CHECK policies */
if (!partition_constraint_failed &&
resultRelInfo->ri_WithCheckOptions != NIL)
{
@ -2549,11 +2548,12 @@ ExecInitModifyTable(ModifyTable *node, EState *estate, int eflags)
/*
* For INSERT and UPDATE, prepare to evaluate any generated columns.
* We must do this now, even if we never insert or update any rows,
* because we have to fill resultRelInfo->ri_extraUpdatedCols for
* possible use by the trigger machinery.
* (This is probably not necessary any longer, but we'll refrain from
* changing it in back branches, in case extension code expects it.)
* During EPQ eval, it might have been done already in an earlier EPQ.
*/
if (operation == CMD_INSERT || operation == CMD_UPDATE)
if ((operation == CMD_INSERT || operation == CMD_UPDATE) &&
resultRelInfo->ri_GeneratedExprs == NULL)
ExecInitStoredGenerated(resultRelInfo, estate, operation);
resultRelInfo++;