database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Revert 019_replslot_limit.pl related debugging aids.

Browse Source 
This reverts most of 91c0570a79, f28bf667f6, fe0972ee5e, afdeff1052. The
only thing left is the retry loop in 019_replslot_limit.pl that avoids
spurious failures by retrying a couple times.

We haven't seen any hard evidence that this is caused by anything but slow
process shutdown. We did not find any cases where walsenders did not vanish
after waiting for longer. Therefore there's no reason for this debugging code
to remain.

Discussion: https://postgr.es/m/20220530190155.47wr3x2prdwyciah@alap3.anarazel.de
Backpatch: 15-
This commit is contained in:
Andres Freund
2022-07-05 11:01:10 -07:00
parent db1fff1ea4
commit 49ddd98763
6 changed files with 5 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/utils/init/postinit.c
View File

@ -1231,24 +1231,6 @@ ShutdownPostgres(int code, Datum arg)
* them explicitly.
*/
LockReleaseAll(USER_LOCKMETHOD, true);
/*
* temp debugging aid to analyze 019_replslot_limit failures
*
* If an error were thrown outside of a transaction nothing up to now
* would have released lwlocks. We probably will add an
* LWLockReleaseAll(). But for now make it easier to understand such cases
* by warning if any lwlocks are held.
*/
#ifdef USE_ASSERT_CHECKING
{
int held_lwlocks = LWLockHeldCount();
if (held_lwlocks)
elog(WARNING, "holding %d lwlocks at the end of ShutdownPostgres()",
held_lwlocks);
}
#endif
}