database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Remove the obsolete WITH clause of CREATE FUNCTION.

Browse Source 
This clause was superseded by SQL-standard syntax back in 7.3.
We've kept it around for backwards-compatibility purposes ever since;
but 15 years seems like long enough for that, especially seeing that
there are undocumented weirdnesses in how it interacts with the
SQL-standard syntax for specifying the same options.

Michael Paquier, per an observation by Daniel Gustafsson;
some small cosmetic adjustments to nearby code by me.

Discussion: https://postgr.es/m/20180115022748.GB1724@paquier.xyz
This commit is contained in:
Tom Lane
2018-01-26 12:25:44 -05:00
parent b0313f9cc8
commit 4971d2a322
6 changed files with 38 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/nodes/copyfuncs.c
View File

@ -3217,7 +3217,7 @@ _copyClosePortalStmt(const ClosePortalStmt *from)
static CallStmt *
_copyCallStmt(const CallStmt *from)
{
CallStmt *newnode = makeNode(CallStmt);
CallStmt *newnode = makeNode(CallStmt);
COPY_NODE_FIELD(funccall);
@ -3422,13 +3422,12 @@ _copyCreateFunctionStmt(const CreateFunctionStmt *from)
{
CreateFunctionStmt *newnode = makeNode(CreateFunctionStmt);
COPY_SCALAR_FIELD(is_procedure);
COPY_SCALAR_FIELD(replace);
COPY_NODE_FIELD(funcname);
COPY_NODE_FIELD(parameters);
COPY_NODE_FIELD(returnType);
COPY_SCALAR_FIELD(is_procedure);
COPY_NODE_FIELD(options);
COPY_NODE_FIELD(withClause);
return newnode;
}