database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-22 14:32:25 +03:00
Code Activity

Fix pg_dump sorting of foreign key constraints

Browse Source 
Apparently, commit 04bc2c42f7 failed to notice that DO_FK_CONSTRAINT
objects require identical handling as DO_CONSTRAINT ones, which causes
some pg_upgrade tests in debug builds to fail spuriously.  Add that.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 13
Discussion: https://postgr.es/m/202510181201.k6y75v2tpf5r@alvherre.pgsql
This commit is contained in:
Álvaro Herrera
2025-10-18 17:50:10 +02:00
parent 5c0a20003b
commit 4921a5972a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_dump/pg_dump_sort.c
View File

@@ -385,7 +385,8 @@ DOTypeNameCompare(const void *p1, const void *p2)
if (cmpval != 0) if (cmpval != 0)
return cmpval; return cmpval;
} }
else if (obj1->objType == DO_CONSTRAINT) else if (obj1->objType == DO_CONSTRAINT ||
obj1->objType == DO_FK_CONSTRAINT)
{ {
ConstraintInfo *robj1 = *(ConstraintInfo *const *) p1; ConstraintInfo *robj1 = *(ConstraintInfo *const *) p1;
ConstraintInfo *robj2 = *(ConstraintInfo *const *) p2; ConstraintInfo *robj2 = *(ConstraintInfo *const *) p2;