database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

Use standard compare_exchange loop style in ProcArrayGroupClearXid().

Browse Source 
Besides style, this might improve performance in the contended case.

Reviewed by Amit Kapila.

Discussion: https://postgr.es/m/20191015035348.GA4166224@rfd.leadboat.com
This commit is contained in:
Noah Misch 2019-10-18 20:21:10 -07:00
parent 30ee5d17c2
commit 48cc59ed24
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/storage/ipc/procarray.c
View File

@ -493,9 +493,9 @@ ProcArrayGroupClearXid(PGPROC *proc, TransactionId latestXid)
/* Add ourselves to the list of processes needing a group XID clear. */ /* Add ourselves to the list of processes needing a group XID clear. */
proc->procArrayGroupMember = true; proc->procArrayGroupMember = true;
proc->procArrayGroupMemberXid = latestXid; proc->procArrayGroupMemberXid = latestXid;
nextidx = pg_atomic_read_u32(&procglobal->procArrayGroupFirst);
while (true) while (true)
{ {
nextidx = pg_atomic_read_u32(&procglobal->procArrayGroupFirst);
pg_atomic_write_u32(&proc->procArrayGroupNext, nextidx); pg_atomic_write_u32(&proc->procArrayGroupNext, nextidx);
if (pg_atomic_compare_exchange_u32(&procglobal->procArrayGroupFirst, if (pg_atomic_compare_exchange_u32(&procglobal->procArrayGroupFirst,