database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-18 05:01:01 +03:00
Code Activity

Fix const qualification in prune_freeze_setup()

Browse Source 
The const qualification of the presult argument to prune_freeze_setup()
is later cast away, so it was not correct. Remove it and add a comment
explaining that presult should not be modified.

Author: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/fb97d0ae-a0bc-411d-8a87-f84e7e146488%40eisentraut.org
This commit is contained in:
Melanie Plageman
2025-12-16 10:29:16 -05:00
parent b39013b7b1
commit 4877391ce8
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/access/heap/pruneheap.c
View File

@@ -160,7 +160,7 @@ typedef struct
static void prune_freeze_setup(PruneFreezeParams *params, static void prune_freeze_setup(PruneFreezeParams *params,
TransactionId *new_relfrozen_xid, TransactionId *new_relfrozen_xid,
MultiXactId *new_relmin_mxid, MultiXactId *new_relmin_mxid,
const PruneFreezeResult *presult, PruneFreezeResult *presult,
PruneState *prstate); PruneState *prstate);
static void prune_freeze_plan(Oid reloid, Buffer buffer, static void prune_freeze_plan(Oid reloid, Buffer buffer,
PruneState *prstate, PruneState *prstate,
@@ -322,12 +322,15 @@ heap_page_prune_opt(Relation relation, Buffer buffer)
/* /*
* Helper for heap_page_prune_and_freeze() to initialize the PruneState using * Helper for heap_page_prune_and_freeze() to initialize the PruneState using
* the provided parameters. * the provided parameters.
*
* params, new_relfrozen_xid, new_relmin_mxid, and presult are input
* parameters and are not modified by this function. Only prstate is modified.
*/ */
static void static void
prune_freeze_setup(PruneFreezeParams *params, prune_freeze_setup(PruneFreezeParams *params,
TransactionId *new_relfrozen_xid, TransactionId *new_relfrozen_xid,
MultiXactId *new_relmin_mxid, MultiXactId *new_relmin_mxid,
const PruneFreezeResult *presult, PruneFreezeResult *presult,
PruneState *prstate) PruneState *prstate)
{ {
/* Copy parameters to prstate */ /* Copy parameters to prstate */
@@ -382,7 +385,7 @@ prune_freeze_setup(PruneFreezeParams *params,
prstate->recently_dead_tuples = 0; prstate->recently_dead_tuples = 0;
prstate->hastup = false; prstate->hastup = false;
prstate->lpdead_items = 0; prstate->lpdead_items = 0;
prstate->deadoffsets = (OffsetNumber *) presult->deadoffsets; prstate->deadoffsets = presult->deadoffsets;
prstate->frz_conflict_horizon = InvalidTransactionId; prstate->frz_conflict_horizon = InvalidTransactionId;
/* /*