mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Revert "Distinguish printf-like functions that support %m from those that don't."
This reverts commit 3a60c8ff89
. Buildfarm
results show that that caused a whole bunch of new warnings on platforms
where gcc believes the local printf to be non-POSIX-compliant. This
problem outweighs the hypothetical-anyway possibility of getting warnings
for misuse of %m. We could use gnu_printf archetype when we've substituted
src/port/snprintf.c, but that brings us right back to the problem of not
getting warnings for %m.
A possible answer is to attack it in the other direction by insisting
that %m support be included in printf's feature set, but that will take
more investigation. In the meantime, revert the previous change, and
update the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explain
what's going on.
Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
This commit is contained in:
6
configure
vendored
6
configure
vendored
@ -13362,8 +13362,8 @@ _ACEOF
|
||||
;;
|
||||
esac
|
||||
|
||||
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for printf format archetype for %m" >&5
|
||||
$as_echo_n "checking for printf format archetype for %m... " >&6; }
|
||||
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for printf format archetype" >&5
|
||||
$as_echo_n "checking for printf format archetype... " >&6; }
|
||||
if ${pgac_cv_printf_archetype+:} false; then :
|
||||
$as_echo_n "(cached) " >&6
|
||||
else
|
||||
@ -13394,7 +13394,7 @@ fi
|
||||
$as_echo "$pgac_cv_printf_archetype" >&6; }
|
||||
|
||||
cat >>confdefs.h <<_ACEOF
|
||||
#define PG_PRINTF_ATTRIBUTE_M $pgac_cv_printf_archetype
|
||||
#define PG_PRINTF_ATTRIBUTE $pgac_cv_printf_archetype
|
||||
_ACEOF
|
||||
|
||||
|
||||
|
Reference in New Issue
Block a user