database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix GiST README's explanation of the NSN cross-check.

Browse Source 
The text got the condition backwards, it's "NSN > LSN", not "NSN < LSN".
While we're at it, expand it a little for clarity.

Reviewed-by: Daniel Gustafsson
Discussion: https://www.postgresql.org/message-id/4cb46e18-e688-524a-0f73-b1f03ed5d6ee@iki.fi
This commit is contained in:
Heikki Linnakangas
2023-09-19 11:53:51 +03:00
parent 35e8ba3e54
commit 459439f728
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/gist/README
View File

@@ -269,10 +269,10 @@ should be visited too. When split inserts the downlink to the parent, it
clears the F_FOLLOW_RIGHT flag in the child, and sets the NSN field in the clears the F_FOLLOW_RIGHT flag in the child, and sets the NSN field in the
child page header to match the LSN of the insertion on the parent. If the child page header to match the LSN of the insertion on the parent. If the
F_FOLLOW_RIGHT flag is not set, a scan compares the NSN on the child and the F_FOLLOW_RIGHT flag is not set, a scan compares the NSN on the child and the
LSN it saw in the parent. If NSN < LSN, the scan looked at the parent page LSN it saw in the parent. If the child's NSN is greater than the LSN seen on
before the downlink was inserted, so it should follow the rightlink. Otherwise the parent, the scan looked at the parent page before the downlink was
the scan saw the downlink in the parent page, and will/did follow that as inserted, so it should follow the rightlink. Otherwise the scan saw the
usual. downlink in the parent page, and will/did follow that as usual.
A scan can't normally see a page with the F_FOLLOW_RIGHT flag set, because A scan can't normally see a page with the F_FOLLOW_RIGHT flag set, because
a page split keeps the child pages locked until the downlink has been inserted a page split keeps the child pages locked until the downlink has been inserted