database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-29 10:41:53 +03:00
Code Activity

Fix ruleutils to print "INSERT INTO foo DEFAULT VALUES" correctly.

Browse Source 
Per bug #7615 from Marko Tiikkaja.  Apparently nobody ever tried this
case before ...
This commit is contained in:
Tom Lane
2012-10-19 13:40:29 -04:00
parent 69d8644374
commit 44ee57a6f2
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/utils/adt/ruleutils.c
View File

@ -3018,8 +3018,8 @@ get_insert_query_def(Query *query, deparse_context *context)
List *strippedexprs; List *strippedexprs;
/* /*
* If it's an INSERT ... SELECT or VALUES (...), (...), ... there will be * If it's an INSERT ... SELECT or multi-row VALUES, there will be a
* a single RTE for the SELECT or VALUES. * single RTE for the SELECT or VALUES. Plain VALUES has neither.
*/ */
foreach(l, query->rtable) foreach(l, query->rtable)
{ {
@ -3053,7 +3053,7 @@ get_insert_query_def(Query *query, deparse_context *context)
context->indentLevel += PRETTYINDENT_STD; context->indentLevel += PRETTYINDENT_STD;
appendStringInfoChar(buf, ' '); appendStringInfoChar(buf, ' ');
} }
appendStringInfo(buf, "INSERT INTO %s (", appendStringInfo(buf, "INSERT INTO %s ",
generate_relation_name(rte->relid, NIL)); generate_relation_name(rte->relid, NIL));
/* /*
@ -3070,6 +3070,8 @@ get_insert_query_def(Query *query, deparse_context *context)
values_cell = NULL; values_cell = NULL;
strippedexprs = NIL; strippedexprs = NIL;
sep = ""; sep = "";
if (query->targetList)
appendStringInfoChar(buf, '(');
foreach(l, query->targetList) foreach(l, query->targetList)
{ {
TargetEntry *tle = (TargetEntry *) lfirst(l); TargetEntry *tle = (TargetEntry *) lfirst(l);
@ -3106,7 +3108,8 @@ get_insert_query_def(Query *query, deparse_context *context)
context, true)); context, true));
} }
} }
appendStringInfo(buf, ") "); if (query->targetList)
appendStringInfo(buf, ") ");
if (select_rte) if (select_rte)
{ {
@ -3121,7 +3124,7 @@ get_insert_query_def(Query *query, deparse_context *context)
/* Add the multi-VALUES expression lists */ /* Add the multi-VALUES expression lists */
get_values_def(values_rte->values_lists, context); get_values_def(values_rte->values_lists, context);
} }
else else if (strippedexprs)
{ {
/* A WITH clause is possible here */ /* A WITH clause is possible here */
get_with_clause(query, context); get_with_clause(query, context);
@ -3131,6 +3134,11 @@ get_insert_query_def(Query *query, deparse_context *context)
get_rule_expr((Node *) strippedexprs, context, false); get_rule_expr((Node *) strippedexprs, context, false);
appendStringInfoChar(buf, ')'); appendStringInfoChar(buf, ')');
} }
else
{
/* No expressions, so it must be DEFAULT VALUES */
appendStringInfo(buf, "DEFAULT VALUES");
}
/* Add RETURNING if present */ /* Add RETURNING if present */
if (query->returningList) if (query->returningList)