database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Select CFLAGS_SL at configure time, not in platform-specific Makefiles.

Browse Source 
Move the platform-dependent logic that sets CFLAGS_SL from
src/makefiles/Makefile.foo to src/template/foo, so that the value
is determined at configure time and thus is available while running
configure's tests.

On a couple of platforms this might save a few microseconds of build
time by eliminating a test that make otherwise has to do over and over.
Otherwise it's pretty much a wash for build purposes; in particular,
this makes no difference to anyone who might be overriding CFLAGS_SL
via a make option.

This patch in itself does nothing with the value and thus should not
change any behavior, though you'll probably have to re-run configure
to get a correctly updated Makefile.global.  We'll use the new
configure variable in a follow-on patch.

Per gripe from Kyotaro Horiguchi.  Back-patch to all supported branches,
because the follow-on patch is a portability bug fix.

Discussion: https://postgr.es/m/20191010.144533.263180400.horikyota.ntt@gmail.com
This commit is contained in:
Tom Lane
2019-10-21 12:32:35 -04:00
parent 80831bcdbe
commit 44273ce4f6
21 changed files with 55 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
configure vendored
View File

@ -728,6 +728,7 @@ autodepend
TAS
GCC
CPP
CFLAGS_SL
BITCODE_CXXFLAGS
BITCODE_CFLAGS
CFLAGS_VECTOR
@ -6579,7 +6580,6 @@ fi
fi
CFLAGS_VECTOR=$CFLAGS_VECTOR
# Determine flags used to emit bitcode for JIT inlining. Need to test
@ -6899,9 +6899,10 @@ CXXFLAGS="$CXXFLAGS $user_CXXFLAGS"
BITCODE_CFLAGS="$BITCODE_CFLAGS $user_BITCODE_CFLAGS"
BITCODE_CXXFLAGS="$BITCODE_CXXFLAGS $user_BITCODE_CXXFLAGS"
BITCODE_CFLAGS=$BITCODE_CFLAGS
BITCODE_CXXFLAGS=$BITCODE_CXXFLAGS
# The template file must set up CFLAGS_SL; we don't support user override
# Check if the compiler still works with the final flag settings