database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00
Code

Update comments for pg_statistic catalog table

Browse Source 
Make a reminder that pg_stats view needs to be modified whenever a new slot
kind is added.  To prevent situations like 918eee0c49 when pg_stats was
forgotten to be updated.

Also, revise the comment that only non-null, non-empty rows are considered
for the range length histogram.

Discussion: https://postgr.es/m/flat/b67d8b57-9357-7e82-a2e7-f6ce6eaeec67@postgrespro.ru
Author: Egor Rogov, Soumyadeep Chakraborty
Reviewed-by: Tomas Vondra, Justin Pryzby, Jian He
This commit is contained in:
Alexander Korotkov 2023-11-27 01:29:56 +02:00
parent 3558f120f8
commit 441c8a3134
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/catalog/pg_statistic.h
View File

@ -152,6 +152,9 @@ DECLARE_FOREIGN_KEY((starelid, staattnum), pg_attribute, (attrelid, attnum));
* data "kind" will appear in any particular slot. Instead, search the * data "kind" will appear in any particular slot. Instead, search the
* stakind fields to see if the desired data is available. (The standard * stakind fields to see if the desired data is available. (The standard
* function get_attstatsslot() may be used for this.) * function get_attstatsslot() may be used for this.)
*
* Note: The pg_stats view needs to be modified whenever a new slot kind is
* added to core.
*/ */
/* /*
@ -262,7 +265,8 @@ DECLARE_FOREIGN_KEY((starelid, staattnum), pg_attribute, (attrelid, attnum));
* a format similar to STATISTIC_KIND_HISTOGRAM: it contains M (>=2) range * a format similar to STATISTIC_KIND_HISTOGRAM: it contains M (>=2) range
* values that divide the column data values into M-1 bins of approximately * values that divide the column data values into M-1 bins of approximately
* equal population. The lengths are stored as float8s, as measured by the * equal population. The lengths are stored as float8s, as measured by the
* range type's subdiff function. Only non-null rows are considered. * range type's subdiff function. Only non-null, non-empty rows are
* considered.
*/ */
#define STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM 6 #define STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM 6