database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

Don't elide blank lines when accumulating psql command history.

Browse Source 
This can change the meaning of queries, if the blank line happens to
occur in the middle of a quoted literal, as per complaint from Tomas Vondra.

Back-patch to all supported branches.
This commit is contained in:
Robert Haas
2011-11-15 20:34:47 -05:00
parent 8fad10a575
commit 43eeaefeea
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/psql/input.c
View File

@ -95,10 +95,10 @@ void
pg_append_history(const char *s, PQExpBuffer history_buf) pg_append_history(const char *s, PQExpBuffer history_buf)
{ {
#ifdef USE_READLINE #ifdef USE_READLINE
if (useHistory && s && s[0]) if (useHistory && s)
{ {
appendPQExpBufferStr(history_buf, s); appendPQExpBufferStr(history_buf, s);
if (s[strlen(s) - 1] != '\n') if (!s[0] || s[strlen(s) - 1] != '\n')
appendPQExpBufferChar(history_buf, '\n'); appendPQExpBufferChar(history_buf, '\n');
} }
#endif #endif