database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-17 17:02:08 +03:00
Code Activity

Assorted minor cleanups in the test_json_parser module

Browse Source 
Per gripes from Michael Paquier

Discussion: https://postgr.es/m/ZhTQ6_w1vwOhqTQI@paquier.xyz

Along the way, also clean up a handful of typos in 3311ea86ed and
ea7b4e9a2a, found by Alexander Lakhin, and a couple of stylistic
snafus noted by Daniel Westermann and Daniel Gustafsson.
This commit is contained in:
Andrew Dunstan
2024-04-09 15:30:48 -04:00
parent b8a7bfa333
commit 42fa4b6601
6 changed files with 43 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/backup/basebackup_incremental.c
View File

@ -34,7 +34,7 @@
#define BLOCKS_PER_READ 512
/*
* we expect the find the last lines of the manifest, including the checksum,
* We expect to find the last lines of the manifest, including the checksum,
* in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
* parse step if we are about to overflow MAX_CHUNK bytes.
*/
@ -88,8 +88,8 @@ struct IncrementalBackupInfo
* Files extracted from the backup manifest.
*
* We don't really need this information, because we use WAL summaries to
* figure what's changed. It would be unsafe to just rely on the list of
* files that existed before, because it's possible for a file to be
* figure out what's changed. It would be unsafe to just rely on the list
* of files that existed before, because it's possible for a file to be
* removed and a new one created with the same name and different
* contents. In such cases, the whole file must still be sent. We can tell
* from the WAL summaries whether that happened, but not from the file