database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

init_fcache was being careless about using SearchSysCacheTuple result

Browse Source 
over multiple lookups --- it should use SearchSysCacheTupleCopy instead.
This accounts for rare failures like 'init_fcache: null probin for procedure 481'
when running concurrently with a VACUUM.
This commit is contained in:
Tom Lane
2000-06-06 17:44:25 +00:00
parent e57e991e80
commit 42ad25fcd1
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/utils/cache/fcache.c vendored
View File

@ -8,12 +8,13 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.31 2000/05/28 17:56:06 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.32 2000/06/06 17:44:25 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
#include "postgres.h" #include "postgres.h"
#include "access/heapam.h"
#include "catalog/pg_language.h" #include "catalog/pg_language.h"
#include "catalog/pg_proc.h" #include "catalog/pg_proc.h"
#include "catalog/pg_type.h" #include "catalog/pg_type.h"
@ -77,11 +78,13 @@ init_fcache(Oid foid,
/* ---------------- /* ----------------
* get the procedure tuple corresponding to the given functionOid * get the procedure tuple corresponding to the given functionOid
*
* NB: use SearchSysCacheTupleCopy to ensure tuple lives long enough
* ---------------- * ----------------
*/ */
procedureTuple = SearchSysCacheTuple(PROCOID, procedureTuple = SearchSysCacheTupleCopy(PROCOID,
ObjectIdGetDatum(foid), ObjectIdGetDatum(foid),
0, 0, 0); 0, 0, 0);
if (!HeapTupleIsValid(procedureTuple)) if (!HeapTupleIsValid(procedureTuple))
elog(ERROR, "init_fcache: Cache lookup failed for procedure %u", elog(ERROR, "init_fcache: Cache lookup failed for procedure %u",
@ -245,6 +248,8 @@ init_fcache(Oid foid,
else else
retval->func.fn_addr = (PGFunction) NULL; retval->func.fn_addr = (PGFunction) NULL;
heap_freetuple(procedureTuple);
return retval; return retval;
} }