database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00
Code

Fix use-after-free bug with event triggers and ALTER TABLE.

Browse Source 
EventTriggerAlterTableEnd neglected to make sure that it built its
output list in the right context.  In simple cases this was masked
because the function is called in PortalContext which will be
sufficiently long-lived anyway; but that doesn't make it not a bug.
Commit ced138e8c fixed this in HEAD and v13, but mistakenly chose
not to back-patch further.  Back-patch the same code change all
the way (I didn't bother with the test case though, as it would
prove nothing in pre-v13 branches).

Per report from Arseny Sher.
Original fix by Jehan-Guillaume de Rorthais.

Discussion: https://postgr.es/m/877drcyprb.fsf@ars-thinkpad
Discussion: https://postgr.es/m/20200902193715.6e0269d4@firost
This commit is contained in:
Tom Lane 2020-10-27 15:37:13 -04:00
parent 38e4b15e03
commit 41c742a432
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/commands/event_trigger.c
View File

@ -1828,9 +1828,15 @@ EventTriggerAlterTableEnd(void)
/* If no subcommands, don't collect */ /* If no subcommands, don't collect */
if (list_length(currentEventTriggerState->currentCommand->d.alterTable.subcmds) != 0) if (list_length(currentEventTriggerState->currentCommand->d.alterTable.subcmds) != 0)
{ {
MemoryContext oldcxt;
oldcxt = MemoryContextSwitchTo(currentEventTriggerState->cxt);
currentEventTriggerState->commandList = currentEventTriggerState->commandList =
lappend(currentEventTriggerState->commandList, lappend(currentEventTriggerState->commandList,
currentEventTriggerState->currentCommand); currentEventTriggerState->currentCommand);
MemoryContextSwitchTo(oldcxt);
} }
else else
pfree(currentEventTriggerState->currentCommand); pfree(currentEventTriggerState->currentCommand);