From 41b023946dfd20acbc4f3b14650a032eb46f5216 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 17 Oct 2024 08:23:46 +0200 Subject: [PATCH] jsonapi: fully initialize dummy lexer Valgrind reports that checks on lex->inc_state are undefined for the "dummy lexer" used for incremental parsing, since it's only partially initialized on the stack. This was introduced in 0785d1b8b2. Zero-initialize the whole struct. Author: Jacob Champion Reported-by: Alexander Lakhin Discussion: https://www.postgresql.org/message-id/CAOYmi+n9QWr4gsAADZc6qFQjFViXQYVk=gBy_EvxuqsgPJcb_g@mail.gmail.com --- src/common/jsonapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/jsonapi.c b/src/common/jsonapi.c index 45838d8a184..ca4ecd571ef 100644 --- a/src/common/jsonapi.c +++ b/src/common/jsonapi.c @@ -1536,7 +1536,7 @@ json_lex(JsonLexContext *lex) jsonapi_StrValType *ptok = &(lex->inc_state->partial_token); size_t added = 0; bool tok_done = false; - JsonLexContext dummy_lex; + JsonLexContext dummy_lex = {0}; JsonParseErrorType partial_result; if (ptok->data[0] == '"')