From 414cd434ff681e5f499803458eae9d5bb32372a9 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 28 Nov 2017 23:25:47 -0300 Subject: [PATCH] Fix extstat collection when no stats are produced for a column This is a mistakenly placed conditional in bf2a691e02d7. Reported by Justin Pryzby Discussion: https://postgr.es/m/20171117214352.GE25796@telsasoft.com --- src/backend/statistics/extended_stats.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c index db4987bde38..eeed56ff0aa 100644 --- a/src/backend/statistics/extended_stats.c +++ b/src/backend/statistics/extended_stats.c @@ -95,15 +95,16 @@ BuildRelationExtStatistics(Relation onerel, double totalrows, */ stats = lookup_var_attr_stats(onerel, stat->columns, natts, vacattrstats); - if (!stats && !IsAutoVacuumWorkerProcess()) + if (!stats) { - ereport(WARNING, - (errcode(ERRCODE_INVALID_OBJECT_DEFINITION), - errmsg("statistics object \"%s.%s\" could not be computed for relation \"%s.%s\"", - stat->schema, stat->name, - get_namespace_name(onerel->rd_rel->relnamespace), - RelationGetRelationName(onerel)), - errtable(onerel))); + if (!IsAutoVacuumWorkerProcess()) + ereport(WARNING, + (errcode(ERRCODE_INVALID_OBJECT_DEFINITION), + errmsg("statistics object \"%s.%s\" could not be computed for relation \"%s.%s\"", + stat->schema, stat->name, + get_namespace_name(onerel->rd_rel->relnamespace), + RelationGetRelationName(onerel)), + errtable(onerel))); continue; }