mirror of
https://github.com/postgres/postgres.git
synced 2025-11-19 13:42:17 +03:00
Make the upper part of the planner work by generating and comparing Paths.
I've been saying we needed to do this for more than five years, and here it finally is. This patch removes the ever-growing tangle of spaghetti logic that grouping_planner() used to use to try to identify the best plan for post-scan/join query steps. Now, there is (nearly) independent consideration of each execution step, and entirely separate construction of Paths to represent each of the possible ways to do that step. We choose the best Path or set of Paths using the same add_path() logic that's been used inside query_planner() for years. In addition, this patch removes the old restriction that subquery_planner() could return only a single Plan. It now returns a RelOptInfo containing a set of Paths, just as query_planner() does, and the parent query level can use each of those Paths as the basis of a SubqueryScanPath at its level. This allows finding some optimizations that we missed before, wherein a subquery was capable of returning presorted data and thereby avoiding a sort in the parent level, making the overall cost cheaper even though delivering sorted output was not the cheapest plan for the subquery in isolation. (A couple of regression test outputs change in consequence of that. However, there is very little change in visible planner behavior overall, because the point of this patch is not to get immediate planning benefits but to create the infrastructure for future improvements.) There is a great deal left to do here. This patch unblocks a lot of planner work that was basically impractical in the old code structure, such as allowing FDWs to implement remote aggregation, or rewriting plan_set_operations() to allow consideration of multiple implementation orders for set operations. (The latter will likely require a full rewrite of plan_set_operations(); what I've done here is only to fix it to return Paths not Plans.) I have also left unfinished some localized refactoring in createplan.c and planner.c, because it was not necessary to get this patch to a working state. Thanks to Robert Haas, David Rowley, and Amit Kapila for review.
This commit is contained in:
@@ -1998,48 +1998,6 @@ add_child_rel_equivalences(PlannerInfo *root,
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* mutate_eclass_expressions
|
||||
* Apply an expression tree mutator to all expressions stored in
|
||||
* equivalence classes (but ignore child exprs unless include_child_exprs).
|
||||
*
|
||||
* This is a bit of a hack ... it's currently needed only by planagg.c,
|
||||
* which needs to do a global search-and-replace of MIN/MAX Aggrefs
|
||||
* after eclasses are already set up. Without changing the eclasses too,
|
||||
* subsequent matching of ORDER BY and DISTINCT clauses would fail.
|
||||
*
|
||||
* Note that we assume the mutation won't affect relation membership or any
|
||||
* other properties we keep track of (which is a bit bogus, but by the time
|
||||
* planagg.c runs, it no longer matters). Also we must be called in the
|
||||
* main planner memory context.
|
||||
*/
|
||||
void
|
||||
mutate_eclass_expressions(PlannerInfo *root,
|
||||
Node *(*mutator) (),
|
||||
void *context,
|
||||
bool include_child_exprs)
|
||||
{
|
||||
ListCell *lc1;
|
||||
|
||||
foreach(lc1, root->eq_classes)
|
||||
{
|
||||
EquivalenceClass *cur_ec = (EquivalenceClass *) lfirst(lc1);
|
||||
ListCell *lc2;
|
||||
|
||||
foreach(lc2, cur_ec->ec_members)
|
||||
{
|
||||
EquivalenceMember *cur_em = (EquivalenceMember *) lfirst(lc2);
|
||||
|
||||
if (cur_em->em_is_child && !include_child_exprs)
|
||||
continue; /* ignore children unless requested */
|
||||
|
||||
cur_em->em_expr = (Expr *)
|
||||
mutator((Node *) cur_em->em_expr, context);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* generate_implied_equalities_for_column
|
||||
* Create EC-derived joinclauses usable with a specific column.
|
||||
|
||||
Reference in New Issue
Block a user