database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-25 01:02:05 +03:00
Code Activity

Fix table_rewrite event trigger for ALTER TYPE/SET DATA TYPE CASCADE

Browse Source 
When a composite type being used in a typed table is modified by way
of ALTER TYPE, a table rewrite occurs appearing to come from ALTER TYPE.
The existing event_trigger.c code was unable to cope with that
and raised a spurious error.  The fix is just to accept that command
tag for the event, and document this properly.

Noted while fooling with deparsing of DDL commands.  This appears to be
an oversight in commit 618c9430a.

Thanks to Mark Wong for documentation wording help.
This commit is contained in:
Alvaro Herrera
2015-02-27 18:38:33 -03:00
parent bda76c1c8c
commit 3f190f67eb
4 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
doc/src/sgml/event-trigger.sgml
View File

@ -68,12 +68,11 @@
<para>
The <literal>table_rewrite</> event occurs just before a table is
rewritten by the command <literal>ALTER TABLE</literal>. While other
rewritten by some actions of the commands <literal>ALTER TABLE</> and
<literal>ALTER TYPE</>. While other
control statements are available to rewrite a table,
like <literal>CLUSTER</literal> and <literal>VACUUM</literal>,
the <literal>table_rewrite</> event is currently only triggered by
the <literal>ALTER TABLE</literal> command, and only when that command
attempts to rewrite the table.
the <literal>table_rewrite</> event is not triggered by them.
</para>
<para>
@ -318,7 +317,7 @@
<entry align="center"><literal>X</literal></entry>
<entry align="center"><literal>X</literal></entry>
<entry align="center"><literal>-</literal></entry>
<entry align="center"><literal>-</literal></entry>
<entry align="center"><literal>X</literal></entry>
<entry align="center"></entry>
</row>
<row>