From 3e527aeeedb0bbbb2388365147ab00cd0f55dfc4 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 27 Dec 2023 10:48:01 +0100 Subject: [PATCH] pg_stat_statements: Add test coverage for pg_stat_statements_reset_1_7 Run pg_stat_statements_reset() once while the appropriate extension version is installed. Reviewed-by: Michael Paquier Discussion: https://www.postgresql.org/message-id/flat/40d1e4f2-835f-448f-a541-8ff5db75bf3d@eisentraut.org --- .../pg_stat_statements/expected/oldextversions.out | 12 ++++++++++++ contrib/pg_stat_statements/sql/oldextversions.sql | 2 ++ 2 files changed, 14 insertions(+) diff --git a/contrib/pg_stat_statements/expected/oldextversions.out b/contrib/pg_stat_statements/expected/oldextversions.out index f3a90cac0af..5842c930e50 100644 --- a/contrib/pg_stat_statements/expected/oldextversions.out +++ b/contrib/pg_stat_statements/expected/oldextversions.out @@ -52,6 +52,12 @@ SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); (1 row) +SELECT pg_stat_statements_reset(); + pg_stat_statements_reset +-------------------------- + +(1 row) + \d pg_stat_statements View "public.pg_stat_statements" Column | Type | Collation | Nullable | Default @@ -330,4 +336,10 @@ SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); (1 row) +SELECT pg_stat_statements_reset() IS NOT NULL AS t; + t +--- + t +(1 row) + DROP EXTENSION pg_stat_statements; diff --git a/contrib/pg_stat_statements/sql/oldextversions.sql b/contrib/pg_stat_statements/sql/oldextversions.sql index 5cf515f6b08..38d5505d0db 100644 --- a/contrib/pg_stat_statements/sql/oldextversions.sql +++ b/contrib/pg_stat_statements/sql/oldextversions.sql @@ -28,6 +28,7 @@ SET SESSION AUTHORIZATION pg_read_all_stats; SELECT pg_stat_statements_reset(); RESET SESSION AUTHORIZATION; SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); +SELECT pg_stat_statements_reset(); \d pg_stat_statements SELECT count(*) > 0 AS has_data FROM pg_stat_statements; @@ -55,5 +56,6 @@ AlTER EXTENSION pg_stat_statements UPDATE TO '1.11'; SELECT count(*) > 0 AS has_data FROM pg_stat_statements; -- New parameter minmax_only of pg_stat_statements_reset function SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); +SELECT pg_stat_statements_reset() IS NOT NULL AS t; DROP EXTENSION pg_stat_statements;