From 3e36e48d8efecea9f2c991c0341e567af2eb363a Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Thu, 30 Nov 2023 09:31:21 +0530 Subject: [PATCH] Fix a test in 003_logical_slots. We allow to upgrade the slot iff there is no pending WAL to be processed. The test first disables the subscription to avoid unnecessary LOGs on the subscriber and then stops the publisher node. It is quite possible that just before the shutdown of the publisher, autovacuum generates some WAL record that needs to be processed, so just disable the autovacuum for this test. Per buildfarm. Author: Hayato Kuroda Reviewed-by: Amit Kapila Discussion: http://postgr.es/m/OS3PR01MB9882FED1F0060468FB01B9DAF583A@OS3PR01MB9882.jpnprd01.prod.outlook.com --- src/bin/pg_upgrade/t/003_logical_slots.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/pg_upgrade/t/003_logical_slots.pl b/src/bin/pg_upgrade/t/003_logical_slots.pl index 5b01cf8c407..087a4cd6e8f 100644 --- a/src/bin/pg_upgrade/t/003_logical_slots.pl +++ b/src/bin/pg_upgrade/t/003_logical_slots.pl @@ -17,6 +17,7 @@ my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy'; # Initialize old cluster my $oldpub = PostgreSQL::Test::Cluster->new('oldpub'); $oldpub->init(allows_streaming => 'logical'); +$oldpub->append_conf('postgresql.conf', 'autovacuum = off'); # Initialize new cluster my $newpub = PostgreSQL::Test::Cluster->new('newpub');