database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-29 22:49:41 +03:00
Code Activity

Fix query checking consistency of table amhandlers in opr_sanity.sql

Browse Source 
As written, the query checked for an access method of type 's', which is
not an AM type supported in the core code.

Error introduced by 8586bf7ed8.  As this query is not checking what it
should, backpatch all the way down.

Reviewed-by: Aleksander Alekseev
Discussion: https://postgr.es/m/ZVxJkAJrKbfHETiy@paquier.xyz
Backpatch-through: 12
This commit is contained in:
Michael Paquier
2023-11-22 09:32:35 +09:00
parent 9dd50e92ed
commit 3dadeef5d9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/regress/expected/opr_sanity.out
View File

@@ -1886,7 +1886,7 @@ WHERE p2.oid = p1.amhandler AND p1.amtype = 'i' AND
-- Check for table amhandler functions with the wrong signature -- Check for table amhandler functions with the wrong signature
SELECT p1.oid, p1.amname, p2.oid, p2.proname SELECT p1.oid, p1.amname, p2.oid, p2.proname
FROM pg_am AS p1, pg_proc AS p2 FROM pg_am AS p1, pg_proc AS p2
WHERE p2.oid = p1.amhandler AND p1.amtype = 's' AND WHERE p2.oid = p1.amhandler AND p1.amtype = 't' AND
(p2.prorettype != 'table_am_handler'::regtype (p2.prorettype != 'table_am_handler'::regtype
OR p2.proretset OR p2.proretset
OR p2.pronargs != 1 OR p2.pronargs != 1

2
src/test/regress/sql/opr_sanity.sql
View File

@@ -1195,7 +1195,7 @@ WHERE p2.oid = p1.amhandler AND p1.amtype = 'i' AND
SELECT p1.oid, p1.amname, p2.oid, p2.proname SELECT p1.oid, p1.amname, p2.oid, p2.proname
FROM pg_am AS p1, pg_proc AS p2 FROM pg_am AS p1, pg_proc AS p2
WHERE p2.oid = p1.amhandler AND p1.amtype = 's' AND WHERE p2.oid = p1.amhandler AND p1.amtype = 't' AND
(p2.prorettype != 'table_am_handler'::regtype (p2.prorettype != 'table_am_handler'::regtype
OR p2.proretset OR p2.proretset
OR p2.pronargs != 1 OR p2.pronargs != 1