database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Fix assertion failure in pg_prewarm() on objects without storage.

Browse Source 
An assertion test added in commit 049ef33 could fail when pg_prewarm()
was called on objects without storage, such as partitioned tables.
This resulted in the following failure in assert-enabled builds:

    Failed Assert("RelFileNumberIsValid(rlocator.relNumber)")

Note that, in non-assert builds, pg_prewarm() just failed with an error
in that case, so there was no ill effect in practice.

This commit fixes the issue by having pg_prewarm() raise an error early
if the specified object has no storage. This approach is similar to
the fix in commit 4623d7144 for pg_freespacemap.

Back-patched to v17, where the issue was introduced.

Author: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/e082e6027610fd0a4091ae6d033aa117@oss.nttdata.com
Backpatch-through: 17
This commit is contained in:
Fujii Masao
2025-05-29 17:50:32 +09:00
parent c3623703f3
commit 3c4d7557e0
5 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
contrib/pg_prewarm/expected/pg_prewarm.out Normal file
View File

@ -0,0 +1,10 @@
-- Test pg_prewarm extension
CREATE EXTENSION pg_prewarm;
-- pg_prewarm() should fail if the target relation has no storage.
CREATE TABLE test (c1 int) PARTITION BY RANGE (c1);
SELECT pg_prewarm('test', 'buffer');
ERROR: relation "test" does not have storage
DETAIL: This operation is not supported for partitioned tables.
-- Cleanup
DROP TABLE test;
DROP EXTENSION pg_prewarm;