1
0
mirror of https://github.com/postgres/postgres.git synced 2025-11-22 12:22:45 +03:00

Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc.

A named tuplestore is necessarily a transient object, so it makes
no sense to reference one in a persistent object such as a view.
We didn't previously prevent that, with the result that if you
tried you would get some weird failure about how the executor
couldn't find the tuplestore.

We can mechanize a check for this case cheaply by making dependency
extraction complain if it comes across such an RTE.  This is a
plausible way of dealing with it since part of the problem is that we
have no way to make a pg_depend representation of a named tuplestore.

Report and fix by Yugo Nagata.  Although this is an old problem,
it's a very weird corner case and there have been no reports from
end users.  So it seems sufficient to fix it in master.

Discussion: https://postgr.es/m/20240726160714.e74d0db579f2c017e1ca0b7e@sraoss.co.jp
This commit is contained in:
Tom Lane
2025-01-08 16:35:54 -05:00
parent b20fe54c9c
commit 3c49d462db
3 changed files with 54 additions and 0 deletions

View File

@@ -2191,7 +2191,22 @@ find_expr_references_walker(Node *node,
}
context->rtables = list_delete_first(context->rtables);
break;
case RTE_NAMEDTUPLESTORE:
/*
* Cataloged objects cannot depend on tuplestores, because
* those have no cataloged representation. For now we can
* call the tuplestore a "transition table" because that's
* the only kind exposed to SQL, but someday we might have
* to work harder.
*/
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("transition table \"%s\" cannot be referenced in a persistent object",
rte->eref->aliasname)));
break;
default:
/* Other RTE types can be ignored here */
break;
}
}