database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-11 10:01:57 +03:00
Code Activity

Improve check for overly-long extensible node name.

Browse Source 
The old code is bad for two reasons.  First, it has an off-by-one
error.  Second, it won't help if you aren't running with assertions
enabled.  Per discussion, we want a check here in that case too.

Author: KaiGai Kohei, adjusted by me.
Reviewed-by: Petr Jelinek
Discussion: 56E0D547.1030101@2ndquadrant.com
This commit is contained in:
Robert Haas
2016-03-14 13:48:35 -04:00
parent 2da7549987
commit 3adf9ced17
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/nodes/extensible.c
View File

@ -51,7 +51,8 @@ RegisterExtensibleNodeMethods(const ExtensibleNodeMethods *methods)
100, &ctl, HASH_ELEM); 100, &ctl, HASH_ELEM);
} }
Assert(strlen(methods->extnodename) <= EXTNODENAME_MAX_LEN); if (strlen(methods->extnodename) >= EXTNODENAME_MAX_LEN)
elog(ERROR, "extensible node name is too long");
entry = (ExtensibleNodeEntry *) hash_search(extensible_node_methods, entry = (ExtensibleNodeEntry *) hash_search(extensible_node_methods,
methods->extnodename, methods->extnodename,