mirror of
https://github.com/postgres/postgres.git
synced 2025-07-03 20:02:46 +03:00
Rename JsonIsPredicate.value_type, fix JSON backend/nodes/ infrastructure.
I started out with the intention to rename value_type to item_type to avoid a collision with a typedef name that appears on some platforms. Along the way, I noticed that the adjacent field "format" was not being correctly handled by the backend/nodes/ infrastructure functions: copyfuncs.c erroneously treated it as a scalar, while equalfuncs, outfuncs, and readfuncs omitted handling it at all. This looks like it might be cosmetic at the moment because the field is always NULL after parse analysis; but that's likely a bug in itself, and the code's certainly not very future-proof. Let's fix it while we can still do so without forcing an initdb on beta testers. Further study found a few other inconsistencies in the backend/nodes/ infrastructure for the recently-added JSON node types, so fix those too. catversion bumped because of potential change in stored rules. Discussion: https://postgr.es/m/526703.1652385613@sss.pgh.pa.us
This commit is contained in:
@ -9730,7 +9730,9 @@ get_rule_expr(Node *node, deparse_context *context,
|
||||
|
||||
appendStringInfoString(context->buf, " IS JSON");
|
||||
|
||||
switch (pred->value_type)
|
||||
/* TODO: handle FORMAT clause */
|
||||
|
||||
switch (pred->item_type)
|
||||
{
|
||||
case JS_TYPE_SCALAR:
|
||||
appendStringInfoString(context->buf, " SCALAR");
|
||||
|
Reference in New Issue
Block a user