mirror of
https://github.com/postgres/postgres.git
synced 2025-07-15 19:21:59 +03:00
Don't fall off the end of perl functions
This complies with the perlcritic policy Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we only currently check at severity level 5, the policy is raised to that level until we move to level 4 or lower, so that any new infringements will be caught. A small cosmetic piece of tidying of the pgperlcritic script is included. Mike Blackwell Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
This commit is contained in:
@ -75,6 +75,7 @@ sub DeterminePlatform
|
||||
$? >> 8 == 0 or die "cl command not found";
|
||||
$self->{platform} = ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : 'Win32';
|
||||
print "Detected hardware platform: $self->{platform}\n";
|
||||
return;
|
||||
}
|
||||
|
||||
# Return 1 if $oldfile is newer than $newfile, or if $newfile doesn't exist.
|
||||
@ -112,6 +113,7 @@ sub copyFile
|
||||
}
|
||||
close($i);
|
||||
close($o);
|
||||
return;
|
||||
}
|
||||
|
||||
sub GenerateFiles
|
||||
@ -533,6 +535,7 @@ EOF
|
||||
<!ENTITY majorversion "$self->{majorver}">
|
||||
EOF
|
||||
close($o);
|
||||
return;
|
||||
}
|
||||
|
||||
sub GenerateDefFile
|
||||
@ -555,6 +558,7 @@ sub GenerateDefFile
|
||||
close($of);
|
||||
close($if);
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
sub AddProject
|
||||
@ -727,6 +731,7 @@ EOF
|
||||
EndGlobal
|
||||
EOF
|
||||
close($sln);
|
||||
return;
|
||||
}
|
||||
|
||||
sub GetFakeConfigure
|
||||
|
Reference in New Issue
Block a user