database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-21 10:42:50 +03:00
Code Activity

Don't fall off the end of perl functions

Browse Source 
This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.

A small cosmetic piece of tidying of the pgperlcritic script is
included.

Mike Blackwell

Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
This commit is contained in:
Andrew Dunstan
2018-05-27 09:08:42 -04:00
parent 8a56ff4848
commit 3a7cc727c7
47 changed files with 208 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/authentication/t/001_password.pl
View File

@@ -31,6 +31,7 @@ sub reset_pg_hba
unlink($node->data_dir . '/pg_hba.conf');
$node->append_conf('pg_hba.conf', "local all all $hba_method");
$node->reload;
return;
}
# Test access for a single role, useful to wrap all tests into one.
@@ -47,6 +48,7 @@ sub test_role
my $res = $node->psql('postgres', undef, extra_params => [ '-U', $role ]);
is($res, $expected_res,
"authentication $status_string for method $method, role $role");
return;
}
# Initialize master node

2
src/test/authentication/t/002_saslprep.pl
View File

@@ -27,6 +27,7 @@ sub reset_pg_hba
unlink($node->data_dir . '/pg_hba.conf');
$node->append_conf('pg_hba.conf', "local all all $hba_method");
$node->reload;
return;
}
# Test access for a single role, useful to wrap all tests into one.
@@ -45,6 +46,7 @@ sub test_login
is($res, $expected_res,
"authentication $status_string for role $role with password $password"
);
return;
}
# Initialize master node. Force UTF-8 encoding, so that we can use non-ASCII