mirror of
https://github.com/postgres/postgres.git
synced 2025-08-18 12:22:09 +03:00
Don't fall off the end of perl functions
This complies with the perlcritic policy Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we only currently check at severity level 5, the policy is raised to that level until we move to level 4 or lower, so that any new infringements will be caught. A small cosmetic piece of tidying of the pgperlcritic script is included. Mike Blackwell Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
This commit is contained in:
@@ -415,6 +415,7 @@ sub main
|
||||
}
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -431,6 +432,7 @@ sub include_file
|
||||
add_to_buffer($buffer, $_);
|
||||
}
|
||||
close($fh);
|
||||
return;
|
||||
}
|
||||
|
||||
sub include_addon
|
||||
@@ -472,6 +474,7 @@ sub include_addon
|
||||
sub add_to_buffer
|
||||
{
|
||||
push(@{ $buff{ $_[0] } }, "$_[1]\n");
|
||||
return;
|
||||
}
|
||||
|
||||
sub dump_buffer
|
||||
@@ -480,6 +483,7 @@ sub dump_buffer
|
||||
print '/* ', $buffer, ' */', "\n";
|
||||
my $ref = $buff{$buffer};
|
||||
print @$ref;
|
||||
return;
|
||||
}
|
||||
|
||||
sub dump_fields
|
||||
@@ -582,6 +586,7 @@ sub dump_fields
|
||||
add_to_buffer('rules', ' { $$ = NULL; }');
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -673,4 +678,5 @@ sub preload_addons
|
||||
push(@{ $x->{lines} }, @code);
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
Reference in New Issue
Block a user