database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Fix the new ARMv8 CRC code for short and unaligned input.

Browse Source 
The code before the main loop, to handle the possible 1-7 unaligned bytes
at the beginning of the input, was broken, and read past the input, if the
the input was very short.
This commit is contained in:
Heikki Linnakangas
2018-04-04 14:40:20 +03:00
parent ee9e145531
commit 3a5e0a91bb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/port/pg_crc32c_armv8.c
View File

@@ -29,17 +29,17 @@ pg_comp_crc32c_armv8(pg_crc32c crc, const void *data, size_t len)
* significantly faster. Process leading bytes so that the loop below * significantly faster. Process leading bytes so that the loop below
* starts with a pointer aligned to eight bytes. * starts with a pointer aligned to eight bytes.
*/ */
if (!PointerIsAligned(p, uint16) && p < pend) if (!PointerIsAligned(p, uint16) && p + 1 <= pend)
{ {
crc = __crc32cb(crc, *p); crc = __crc32cb(crc, *p);
p += 1; p += 1;
} }
if (!PointerIsAligned(p, uint32) && p < pend) if (!PointerIsAligned(p, uint32) && p + 2 <= pend)
{ {
crc = __crc32ch(crc, *(uint16 *) p); crc = __crc32ch(crc, *(uint16 *) p);
p += 2; p += 2;
} }
if (!PointerIsAligned(p, uint64) && p < pend) if (!PointerIsAligned(p, uint64) && p + 4 <= pend)
{ {
crc = __crc32cw(crc, *(uint32 *) p); crc = __crc32cw(crc, *(uint32 *) p);
p += 4; p += 4;