From 39cdf365a38416f2f31429db9656ccfcb65ccd69 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Sun, 4 Jan 2015 15:35:47 +0100 Subject: [PATCH] Add missing va_end() call to a early exit in dmetaphone.c's StringAt(). Pointed out by Coverity. Backpatch to all supported branches, the code has been that way for a long while. --- contrib/fuzzystrmatch/dmetaphone.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/fuzzystrmatch/dmetaphone.c b/contrib/fuzzystrmatch/dmetaphone.c index 6721e58f220..5ad2ed532af 100644 --- a/contrib/fuzzystrmatch/dmetaphone.c +++ b/contrib/fuzzystrmatch/dmetaphone.c @@ -362,7 +362,10 @@ StringAt(metastring *s, int start, int length,...) { test = va_arg(ap, char *); if (*test && (strncmp(pos, test, length) == 0)) + { + va_end(ap); return 1; + } } while (strcmp(test, ""));