database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-08 07:21:33 +03:00
Code

Maintain valid md.c state when FileClose() fails.

Browse Source 
FileClose() failure ordinarily causes a PANIC.  Suppose the user
disables that PANIC via data_sync_retry=on.  After mdclose() issued a
FileClose() that failed, calls into md.c raised SIGSEGV.  This fix adds
repalloc() calls during mdclose(); update a comment about ignoring
repalloc() cost.  The rate of relation segment count change is a minor
factor; more relevant to overall performance is the rate of mdclose()
and subsequent re-opening of segments.  Back-patch to v10, where commit
45e191e3aa62d47a8bc1a33f784286b2051f45cb introduced the bug.

Reviewed by Kyotaro Horiguchi.

Discussion: https://postgr.es/m/20191222091930.GA1280238@rfd.leadboat.com
This commit is contained in:
Noah Misch 2020-01-10 18:31:22 -08:00
parent 1a4a032965
commit 38fc056074
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/storage/smgr/md.c
View File

@ -516,18 +516,10 @@ mdclose(SMgrRelation reln, ForkNumber forknum)
{ {
MdfdVec *v = &reln->md_seg_fds[forknum][nopensegs - 1]; MdfdVec *v = &reln->md_seg_fds[forknum][nopensegs - 1];
/* if not closed already */
if (v->mdfd_vfd >= 0)
{
FileClose(v->mdfd_vfd); FileClose(v->mdfd_vfd);
v->mdfd_vfd = -1; _fdvec_resize(reln, forknum, nopensegs - 1);
}
nopensegs--; nopensegs--;
} }
/* resize just once, avoids pointless reallocations */
_fdvec_resize(reln, forknum, 0);
} }
/* /*
@ -1050,10 +1042,10 @@ _fdvec_resize(SMgrRelation reln,
else else
{ {
/* /*
* It doesn't seem worthwhile complicating the code by having a more * It doesn't seem worthwhile complicating the code to amortize
* aggressive growth strategy here; the number of segments doesn't * repalloc() calls. Those are far faster than PathNameOpenFile() or
* grow that fast, and the memory context internally will sometimes * FileClose(), and the memory context internally will sometimes avoid
* avoid doing an actual reallocation. * doing an actual reallocation.
*/ */
reln->md_seg_fds[forknum] = reln->md_seg_fds[forknum] =
repalloc(reln->md_seg_fds[forknum], repalloc(reln->md_seg_fds[forknum],