Clean up rewriter routines to use expression_tree_walker and

Browse Source

expression_tree_mutator rather than ad-hoc tree walking code.  This shortens
the code materially and fixes a fair number of sins of omission.  Also,
change modifyAggrefQual to *not* recurse into subselects, since its mission
is satisfied if it removes aggregate functions from the top level of a
WHERE clause.  This cures problems with queries of the form SELECT ...
WHERE x IN (SELECT ... HAVING something-using-an-aggregate), which would
formerly get mucked up by modifyAggrefQual.  The routine is still
fundamentally broken, of course, but I don't think there's any way to get
rid of it before we implement subselects in FROM ...

...

This commit is contained in:

Tom Lane

1999-10-01 04:08:24 +00:00

parent ce1f5ed547

commit 389af07cf0

4 changed files with 1003 additions and 2481 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

1254

src/backend/rewrite/rewriteManip.c

File diff suppressed because it is too large Load Diff