mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
perl: Hide warnings inside perl.h when using gcc compatible compiler
New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC system_header before including plperl.h. Alternatively, we could add the include paths for problematic headers with -isystem, but that is a larger hammer and is harder to search for. A more granular alternative would be to use #pragma GCC diagnostic push/ignored/pop, but gcc warns about unknown warnings being ignored, so every to-be-ignored-temporarily compiler warning would require its own pg_config.h symbol and #ifdef. As the warnings are voluminous, it makes sense to backpatch this change. But don't do so yet, we first want gather buildfarm coverage - it's e.g. possible that some compiler claiming to be gcc compatible has issues with the pragma. Author: Andres Freund <andres@anarazel.de> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: Discussion: https://postgr.es/m/20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de
This commit is contained in:
@ -74,6 +74,15 @@
|
||||
#define HAS_BOOL 1
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Newer versions of the perl headers trigger a lot of warnings with our
|
||||
* compiler flags (at least -Wdeclaration-after-statement,
|
||||
* -Wshadow=compatible-local are known to be problematic). The system_header
|
||||
* pragma hides warnings from within the rest of this file, if supported.
|
||||
*/
|
||||
#ifdef HAVE_PRAGMA_GCC_SYSTEM_HEADER
|
||||
#pragma GCC system_header
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Get the basic Perl API. We use PERL_NO_GET_CONTEXT mode so that our code
|
||||
|
Reference in New Issue
Block a user