database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-05 23:56:58 +03:00
Code

Remove unused argument from ginInsertCleanup()

Browse Source 
It's an oversight in commit dc943ad.
This commit is contained in:
Fujii Masao 2016-01-22 01:22:56 +09:00
parent c80b31d557
commit 38710a374e
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/gin/ginfast.c
View File

@ -434,7 +434,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
END_CRIT_SECTION(); END_CRIT_SECTION();
if (needCleanup) if (needCleanup)
ginInsertCleanup(ginstate, false, true, NULL); ginInsertCleanup(ginstate, true, NULL);
} }
/* /*
@ -732,9 +732,6 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
* action of removing a page from the pending list really needs exclusive * action of removing a page from the pending list really needs exclusive
* lock. * lock.
* *
* vac_delay indicates that ginInsertCleanup should call
* vacuum_delay_point() periodically.
*
* fill_fsm indicates that ginInsertCleanup should add deleted pages * fill_fsm indicates that ginInsertCleanup should add deleted pages
* to FSM otherwise caller is responsible to put deleted pages into * to FSM otherwise caller is responsible to put deleted pages into
* FSM. * FSM.
@ -743,8 +740,7 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
*/ */
void void
ginInsertCleanup(GinState *ginstate, ginInsertCleanup(GinState *ginstate,
bool vac_delay, bool fill_fsm, bool fill_fsm, IndexBulkDeleteResult *stats)
IndexBulkDeleteResult *stats)
{ {
Relation index = ginstate->index; Relation index = ginstate->index;
Buffer metabuffer, Buffer metabuffer,

6
src/backend/access/gin/ginvacuum.c
View File

@ -541,7 +541,7 @@ ginbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
/* Yes, so initialize stats to zeroes */ /* Yes, so initialize stats to zeroes */
stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult)); stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
/* and cleanup any pending inserts */ /* and cleanup any pending inserts */
ginInsertCleanup(&gvs.ginstate, true, false, stats); ginInsertCleanup(&gvs.ginstate, false, stats);
} }
/* we'll re-count the tuples each time */ /* we'll re-count the tuples each time */
@ -654,7 +654,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
if (IsAutoVacuumWorkerProcess()) if (IsAutoVacuumWorkerProcess())
{ {
initGinState(&ginstate, index); initGinState(&ginstate, index);
ginInsertCleanup(&ginstate, true, true, stats); ginInsertCleanup(&ginstate, true, stats);
} }
return stats; return stats;
} }
@ -667,7 +667,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
{ {
stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult)); stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
initGinState(&ginstate, index); initGinState(&ginstate, index);
ginInsertCleanup(&ginstate, true, false, stats); ginInsertCleanup(&ginstate, false, stats);
} }
memset(&idxStat, 0, sizeof(idxStat)); memset(&idxStat, 0, sizeof(idxStat));

2
src/include/access/gin_private.h
View File

@ -946,7 +946,7 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,
OffsetNumber attnum, Datum value, bool isNull, OffsetNumber attnum, Datum value, bool isNull,
ItemPointer ht_ctid); ItemPointer ht_ctid);
extern void ginInsertCleanup(GinState *ginstate, extern void ginInsertCleanup(GinState *ginstate,
bool vac_delay, bool fill_fsm, IndexBulkDeleteResult *stats); bool fill_fsm, IndexBulkDeleteResult *stats);
/* ginpostinglist.c */ /* ginpostinglist.c */