database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-29 10:41:53 +03:00
Code Activity

Error out on send failure in walsender loop.

Browse Source 
I changed the loop in 9.3 to use "goto send_failure" instead of "break" on
errors, but I missed this one case. It was a relatively harmless bug: if
the flush fails once it will most likely fail again as soon as we try to
flush the output again. But it's a bug nevertheless.

Report and fix by Andres Freund.
This commit is contained in:
Heikki Linnakangas
2014-03-04 15:30:52 +02:00
parent f5f21315d2
commit 38587d7d28
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/walsender.c
View File

@ -1100,7 +1100,7 @@ WalSndLoop(void)
ping_sent = true; ping_sent = true;
/* Try to flush pending output to the client */ /* Try to flush pending output to the client */
if (pq_flush_if_writable() != 0) if (pq_flush_if_writable() != 0)
break; goto send_failure;
} }
} }