database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

Install a search tree depth limit in GIN bulk-insert operations, to prevent

Browse Source 
them from degrading badly when the input is sorted or nearly so.  In this
scenario the tree is unbalanced to the point of becoming a mere linked list,
so insertions become O(N^2).  The easiest and most safely back-patchable
solution is to stop growing the tree sooner, ie limit the growth of N.  We
might later consider a rebalancing tree algorithm, but it's not clear that
the benefit would be worth the cost and complexity.  Per report from Sergey
Burladyan and an earlier complaint from Heikki.

Back-patch to 8.2; older versions didn't have GIN indexes.
This commit is contained in:
Tom Lane 2009-03-24 22:06:32 +00:00
parent 98686e1ea1
commit 37e9992214
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/access/gin/gininsert.c
View File

@ -8,7 +8,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/gin/gininsert.c,v 1.5.2.1 2007/06/05 12:48:21 teodor Exp $ * $PostgreSQL: pgsql/src/backend/access/gin/gininsert.c,v 1.5.2.2 2009/03/24 22:06:32 tgl Exp $
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -241,7 +241,8 @@ ginBuildCallback(Relation index, HeapTuple htup, Datum *values,
* we use only half maintenance_work_mem, because there is some leaks * we use only half maintenance_work_mem, because there is some leaks
* during insertion and extract values * during insertion and extract values
*/ */
if (buildstate->accum.allocatedMemory >= maintenance_work_mem * 1024L / 2L) if (buildstate->accum.allocatedMemory >= maintenance_work_mem * 1024L / 2L ||
buildstate->accum.maxdepth > GIN_MAX_TREE_DEPTH)
{ {
ItemPointerData *list; ItemPointerData *list;
Datum entry; Datum entry;

17
src/include/access/gin.h
View File

@ -3,7 +3,7 @@
* header file for postgres inverted index access method implementation. * header file for postgres inverted index access method implementation.
* *
* Copyright (c) 2006, PostgreSQL Global Development Group * Copyright (c) 2006, PostgreSQL Global Development Group
* $PostgreSQL: pgsql/src/include/access/gin.h,v 1.9.2.2 2008/04/22 17:53:41 teodor Exp $ * $PostgreSQL: pgsql/src/include/access/gin.h,v 1.9.2.3 2009/03/24 22:06:32 tgl Exp $
*-------------------------------------------------------------------------- *--------------------------------------------------------------------------
*/ */
@ -33,6 +33,14 @@
typedef XLogRecPtr GinNSN; typedef XLogRecPtr GinNSN;
/*
* Max depth allowed in search tree during bulk inserts. This is to keep from
* degenerating to O(N^2) behavior when the tree is unbalanced due to sorted
* or nearly-sorted input. (Perhaps it would be better to use a balanced-tree
* algorithm, but in common cases that would only add useless overhead.)
*/
#define GIN_MAX_TREE_DEPTH 100
/* /*
* Page opaque data in a inverted index page. * Page opaque data in a inverted index page.
*/ */
@ -314,12 +322,9 @@ extern IndexTuple ginPageGetLinkItup(Buffer buf);
/* gindatapage.c */ /* gindatapage.c */
extern int compareItemPointers(ItemPointer a, ItemPointer b); extern int compareItemPointers(ItemPointer a, ItemPointer b);
extern void extern void MergeItemPointers(ItemPointerData *dst,
MergeItemPointers(
ItemPointerData *dst,
ItemPointerData *a, uint32 na, ItemPointerData *a, uint32 na,
ItemPointerData *b, uint32 nb ItemPointerData *b, uint32 nb);
);
extern void GinDataPageAddItem(Page page, void *data, OffsetNumber offset); extern void GinDataPageAddItem(Page page, void *data, OffsetNumber offset);
extern void PageDeletePostingItem(Page page, OffsetNumber offset); extern void PageDeletePostingItem(Page page, OffsetNumber offset);