From 37c6923cf3d8ec1bd44924aab6f58f72754a0e7b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 24 Jul 2024 06:21:40 +0200 Subject: [PATCH] Fix -Wmissing-variable-declarations warnings for float.c special case This adds extern declarations for the global variables defined in float.c but not meant for external use. This is a workaround to be able to add -Wmissing-variable-declarations to the global set of warning options in the near future. Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org --- src/backend/utils/adt/float.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c index cbbb8aecafc..f709c21e1fe 100644 --- a/src/backend/utils/adt/float.c +++ b/src/backend/utils/adt/float.c @@ -55,7 +55,15 @@ static float8 cot_45 = 0; * be referenced by other files, much less changed; but we don't want the * compiler to know that, else it might try to precompute expressions * involving them. See comments for init_degree_constants(). + * + * The additional extern declarations are to silence + * -Wmissing-variable-declarations. */ +extern float8 degree_c_thirty; +extern float8 degree_c_forty_five; +extern float8 degree_c_sixty; +extern float8 degree_c_one_half; +extern float8 degree_c_one; float8 degree_c_thirty = 30.0; float8 degree_c_forty_five = 45.0; float8 degree_c_sixty = 60.0;