From 37afc079abe1986b4af94aa8ec28cefd663aaae6 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 17 Nov 2018 16:31:07 -0500 Subject: [PATCH] Avoid defining SIGTTIN/SIGTTOU on Windows. Setting them to SIG_IGN seems unlikely to have any beneficial effect on that platform, and given the signal numbering collision with SIGABRT, it could easily have bad effects. Given the lack of field complaints that can be traced to this, I don't presently feel a need to back-patch. Discussion: https://postgr.es/m/5627.1542477392@sss.pgh.pa.us --- src/backend/postmaster/postmaster.c | 4 ++++ src/include/port/win32_port.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index 68bb35ab791..a33a1311829 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -654,8 +654,12 @@ PostmasterMain(int argc, char *argv[]) * a standalone backend, their default handling is reasonable. Hence, all * child processes should just allow the inherited settings to stand. */ +#ifdef SIGTTIN pqsignal(SIGTTIN, SIG_IGN); /* ignored */ +#endif +#ifdef SIGTTOU pqsignal(SIGTTOU, SIG_IGN); /* ignored */ +#endif /* ignore SIGXFSZ, so that ulimit violations work like disk full */ #ifdef SIGXFSZ diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h index 360dbdf3a75..f9d351f20b7 100644 --- a/src/include/port/win32_port.h +++ b/src/include/port/win32_port.h @@ -171,8 +171,6 @@ #define SIGTSTP 18 #define SIGCONT 19 #define SIGCHLD 20 -#define SIGTTIN 21 -#define SIGTTOU 22 /* Same as SIGABRT -- no problem, I hope */ #define SIGWINCH 28 #define SIGUSR1 30 #define SIGUSR2 31