mirror of
https://github.com/postgres/postgres.git
synced 2025-08-19 23:22:23 +03:00
Support domains over composite types.
This is the last major omission in our domains feature: you can now make a domain over anything that's not a pseudotype. The major complication from an implementation standpoint is that places that might be creating tuples of a domain type now need to be prepared to apply domain_check(). It seems better that unprepared code fail with an error like "<type> is not composite" than that it silently fail to apply domain constraints. Therefore, relevant infrastructure like get_func_result_type() and lookup_rowtype_tupdesc() has been adjusted to treat domain-over-composite as a distinct case that unprepared code won't recognize, rather than just transparently treating it the same as plain composite. This isn't a 100% solution to the possibility of overlooked domain checks, but it catches most places. In passing, improve typcache.c's support for domains (it can now cache the identity of a domain's base type), and rewrite the argument handling logic in jsonfuncs.c's populate_record[set]_worker to reduce duplicative per-call lookups. I believe this is code-complete so far as the core and contrib code go. The PLs need varying amounts of work, which will be tackled in followup patches. Discussion: https://postgr.es/m/4206.1499798337@sss.pgh.pa.us
This commit is contained in:
@@ -166,7 +166,7 @@ typedef struct Var
|
||||
Index varno; /* index of this var's relation in the range
|
||||
* table, or INNER_VAR/OUTER_VAR/INDEX_VAR */
|
||||
AttrNumber varattno; /* attribute number of this var, or zero for
|
||||
* all */
|
||||
* all attrs ("whole-row Var") */
|
||||
Oid vartype; /* pg_type OID for the type of this var */
|
||||
int32 vartypmod; /* pg_attribute typmod value */
|
||||
Oid varcollid; /* OID of collation, or InvalidOid if none */
|
||||
@@ -755,6 +755,9 @@ typedef struct FieldSelect
|
||||
* the assign case of ArrayRef, this is used to implement UPDATE of a
|
||||
* portion of a column.
|
||||
*
|
||||
* resulttype is always a named composite type (not a domain). To update
|
||||
* a composite domain value, apply CoerceToDomain to the FieldStore.
|
||||
*
|
||||
* A single FieldStore can actually represent updates of several different
|
||||
* fields. The parser only generates FieldStores with single-element lists,
|
||||
* but the planner will collapse multiple updates of the same base column
|
||||
@@ -849,7 +852,8 @@ typedef struct ArrayCoerceExpr
|
||||
* needed for the destination type plus possibly others; the columns need not
|
||||
* be in the same positions, but are matched up by name. This is primarily
|
||||
* used to convert a whole-row value of an inheritance child table into a
|
||||
* valid whole-row value of its parent table's rowtype.
|
||||
* valid whole-row value of its parent table's rowtype. Both resulttype
|
||||
* and the exposed type of "arg" must be named composite types (not domains).
|
||||
* ----------------
|
||||
*/
|
||||
|
||||
@@ -987,6 +991,9 @@ typedef struct RowExpr
|
||||
Oid row_typeid; /* RECORDOID or a composite type's ID */
|
||||
|
||||
/*
|
||||
* row_typeid cannot be a domain over composite, only plain composite. To
|
||||
* create a composite domain value, apply CoerceToDomain to the RowExpr.
|
||||
*
|
||||
* Note: we deliberately do NOT store a typmod. Although a typmod will be
|
||||
* associated with specific RECORD types at runtime, it will differ for
|
||||
* different backends, and so cannot safely be stored in stored
|
||||
|
Reference in New Issue
Block a user