mirror of
https://github.com/postgres/postgres.git
synced 2025-10-21 02:52:47 +03:00
Support domains over composite types.
This is the last major omission in our domains feature: you can now make a domain over anything that's not a pseudotype. The major complication from an implementation standpoint is that places that might be creating tuples of a domain type now need to be prepared to apply domain_check(). It seems better that unprepared code fail with an error like "<type> is not composite" than that it silently fail to apply domain constraints. Therefore, relevant infrastructure like get_func_result_type() and lookup_rowtype_tupdesc() has been adjusted to treat domain-over-composite as a distinct case that unprepared code won't recognize, rather than just transparently treating it the same as plain composite. This isn't a 100% solution to the possibility of overlooked domain checks, but it catches most places. In passing, improve typcache.c's support for domains (it can now cache the identity of a domain's base type), and rewrite the argument handling logic in jsonfuncs.c's populate_record[set]_worker to reduce duplicative per-call lookups. I believe this is code-complete so far as the core and contrib code go. The PLs need varying amounts of work, which will be tackled in followup patches. Discussion: https://postgr.es/m/4206.1499798337@sss.pgh.pa.us
This commit is contained in:
@@ -134,6 +134,11 @@ typedef struct DatumTupleFields
|
||||
Oid datum_typeid; /* composite type OID, or RECORDOID */
|
||||
|
||||
/*
|
||||
* datum_typeid cannot be a domain over composite, only plain composite,
|
||||
* even if the datum is meant as a value of a domain-over-composite type.
|
||||
* This is in line with the general principle that CoerceToDomain does not
|
||||
* change the physical representation of the base type value.
|
||||
*
|
||||
* Note: field ordering is chosen with thought that Oid might someday
|
||||
* widen to 64 bits.
|
||||
*/
|
||||
|
@@ -60,6 +60,12 @@ typedef struct tupleConstr
|
||||
* row type, or a value >= 0 to allow the rowtype to be looked up in the
|
||||
* typcache.c type cache.
|
||||
*
|
||||
* Note that tdtypeid is never the OID of a domain over composite, even if
|
||||
* we are dealing with values that are known (at some higher level) to be of
|
||||
* a domain-over-composite type. This is because tdtypeid/tdtypmod need to
|
||||
* match up with the type labeling of composite Datums, and those are never
|
||||
* explicitly marked as being of a domain type, either.
|
||||
*
|
||||
* Tuple descriptors that live in caches (relcache or typcache, at present)
|
||||
* are reference-counted: they can be deleted when their reference count goes
|
||||
* to zero. Tuple descriptors created by the executor need no reference
|
||||
|
Reference in New Issue
Block a user