database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-19 13:42:17 +03:00
Code Activity

Check for tabs in postgresql.conf.sample.

Browse Source 
The previous commit updated this file to use spaces instead of
tabs.  This commit adds a test to ensure that no new tabs are
added.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/aReNUKdMgKxLqmq7%40nathan
This commit is contained in:
Nathan Bossart
2025-11-18 10:28:36 -06:00
parent f63ae72bbc
commit 379f0e9f72
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/modules/test_misc/t/003_check_guc.pl
View File

@@ -44,13 +44,21 @@ my $sample_file = "$share_dir/postgresql.conf.sample";
# List of all the GUCs found in the sample file. # List of all the GUCs found in the sample file.
my @gucs_in_file; my @gucs_in_file;
# List of all lines with tabs in the sample file.
my @lines_with_tabs;
# Read the sample file line-by-line, checking its contents to build a list # Read the sample file line-by-line, checking its contents to build a list
# of everything known as a GUC. # of everything known as a GUC.
my $num_tests = 0; my $num_tests = 0;
my $line_num = 0;
open(my $contents, '<', $sample_file) open(my $contents, '<', $sample_file)
|| die "Could not open $sample_file: $!"; || die "Could not open $sample_file: $!";
while (my $line = <$contents>) while (my $line = <$contents>)
{ {
$line_num++;
push @lines_with_tabs, $line_num
if $line =~ /\t/;
# Check if this line matches a GUC parameter: # Check if this line matches a GUC parameter:
# - Each parameter is preceded by "#", but not "# " in the sample # - Each parameter is preceded by "#", but not "# " in the sample
# file. # file.
@@ -97,6 +105,8 @@ my @sample_intersect = grep($not_in_sample_hash{$_}, @gucs_in_file);
is(scalar(@sample_intersect), is(scalar(@sample_intersect),
0, "no parameters marked as NOT_IN_SAMPLE in postgresql.conf.sample"); 0, "no parameters marked as NOT_IN_SAMPLE in postgresql.conf.sample");
is(scalar(@lines_with_tabs), 0, "no lines with tabs in postgresql.conf.sample");
# These would log some information only on errors. # These would log some information only on errors.
foreach my $param (@missing_from_file) foreach my $param (@missing_from_file)
{ {
@@ -116,5 +126,9 @@ foreach my $param (@sample_intersect)
"found GUC $param in postgresql.conf.sample, marked as NOT_IN_SAMPLE\n" "found GUC $param in postgresql.conf.sample, marked as NOT_IN_SAMPLE\n"
); );
} }
foreach my $param (@lines_with_tabs)
{
print("found tab in line $param in postgresql.conf.sample\n");
}
done_testing(); done_testing();