database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Use C library functions instead of Abs() for int64

Browse Source 
Instead of Abs() for int64, use the C standard functions labs() or
llabs() as appropriate.  Define a small wrapper around them that
matches our definition of int64.  (labs() is C90, llabs() is C99.)

Reviewed-by: Zhang Mingli <zmlpostgres@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/4beb42b5-216b-bce8-d452-d924d5794c63%40enterprisedb.com
This commit is contained in:
Peter Eisentraut
2022-10-10 08:51:07 +02:00
parent 06dbd619bf
commit 357cfefb09
5 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/utils/adt/datetime.c
View File

@ -4468,7 +4468,7 @@ AddVerboseIntPart(char *cp, int64 value, const char *units,
if (*is_zero)
{
*is_before = (value < 0);
value = Abs(value);
value = i64abs(value);
}
else if (*is_before)
value = -value;
@ -4569,8 +4569,8 @@ EncodeInterval(struct pg_itm *itm, int style, char *str)
sprintf(cp, "%c%d-%d %c%lld %c%lld:%02d:",
year_sign, abs(year), abs(mon),
day_sign, (long long) Abs(mday),
sec_sign, (long long) Abs(hour), abs(min));
day_sign, (long long) i64abs(mday),
sec_sign, (long long) i64abs(hour), abs(min));
cp += strlen(cp);
cp = AppendSeconds(cp, sec, fsec, MAX_INTERVAL_PRECISION, true);
*cp = '\0';
@ -4642,7 +4642,7 @@ EncodeInterval(struct pg_itm *itm, int style, char *str)
sprintf(cp, "%s%s%02lld:%02d:",
is_zero ? "" : " ",
(minus ? "-" : (is_before ? "+" : "")),
(long long) Abs(hour), abs(min));
(long long) i64abs(hour), abs(min));
cp += strlen(cp);
cp = AppendSeconds(cp, sec, fsec, MAX_INTERVAL_PRECISION, true);
*cp = '\0';