1
0
mirror of https://github.com/postgres/postgres.git synced 2025-06-26 12:21:12 +03:00

Reset, not recreate, execGrouping.c style hashtables.

This uses the facility added in the preceding commit to fix
performance issues caused by rebuilding the hashtable (with its
comparator expression being the most expensive bit), after every
reset. That's especially important when the comparator is JIT
compiled.

Bug: #15592 #15486
Reported-By: Jakub Janeček, Dmitry Marakasov
Author: Andres Freund
Discussion:
    https://postgr.es/m/15486-05850f065da42931@postgresql.org
    https://postgr.es/m/20190114180423.ywhdg2iagzvh43we@alap3.anarazel.de
Backpatch: 11, where I broke this in bf6c614a2f
This commit is contained in:
Andres Freund
2019-02-09 00:35:57 -08:00
parent 317ffdfeaa
commit 356687bd82
4 changed files with 79 additions and 64 deletions

View File

@ -37,17 +37,18 @@ build_hash_table(RecursiveUnionState *rustate)
Assert(node->numCols > 0);
Assert(node->numGroups > 0);
rustate->hashtable = BuildTupleHashTable(&rustate->ps,
desc,
node->numCols,
node->dupColIdx,
rustate->eqfuncoids,
rustate->hashfunctions,
node->numGroups,
0,
rustate->tableContext,
rustate->tempContext,
false);
rustate->hashtable = BuildTupleHashTableExt(&rustate->ps,
desc,
node->numCols,
node->dupColIdx,
rustate->eqfuncoids,
rustate->hashfunctions,
node->numGroups,
0,
rustate->ps.state->es_query_cxt,
rustate->tableContext,
rustate->tempContext,
false);
}
@ -317,9 +318,9 @@ ExecReScanRecursiveUnion(RecursiveUnionState *node)
if (node->tableContext)
MemoryContextResetAndDeleteChildren(node->tableContext);
/* And rebuild empty hashtable if needed */
/* Empty hashtable if needed */
if (plan->numCols > 0)
build_hash_table(node);
ResetTupleHashTable(node->hashtable);
/* reset processing state */
node->recursing = false;