database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^31.

Browse Source 
Commit aa0105141 repeated one of the oldest mistakes in our book:
thinking that OID is the same as int32.  It isn't of course, and
unsurprisingly the first person who came along with a database
OID above 2 billion broke it.  Repair.

Per bug #17677 from Sergey Pankov.  Back-patch to v15.

Discussion: https://postgr.es/m/17677-a99fa067d7ed71c9@postgresql.org
This commit is contained in:
Tom Lane
2022-11-04 10:39:52 -04:00
parent 8c71467908
commit 34fa0ddae5
4 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/commands/dbcommands.c
View File

@ -816,7 +816,7 @@ createdb(ParseState *pstate, const CreatedbStmt *stmt)
}
else if (strcmp(defel->defname, "oid") == 0)
{
dboid = defGetInt32(defel);
dboid = defGetObjectId(defel);
/*
* We don't normally permit new databases to be created with