database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Fix parsing of DROP SUBSCRIPTION ... DROP SLOT

Browse Source 
It didn't actually parse before.

Reported-by: Masahiko Sawada <sawada.mshk@gmail.com>
This commit is contained in:
Peter Eisentraut
2017-03-03 22:14:58 -05:00
parent 1309375e70
commit 347302730d
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/parser/gram.y
View File

@@ -9196,11 +9196,13 @@ DropSubscriptionStmt: DROP SUBSCRIPTION name opt_drop_slot
; ;
opt_drop_slot: opt_drop_slot:
IDENT SLOT DROP SLOT
{ {
if (strcmp($1, "drop") == 0) $$ = TRUE;
$$ = TRUE; }
else if (strcmp($1, "nodrop") == 0) | IDENT SLOT
{
if (strcmp($1, "nodrop") == 0)
$$ = FALSE; $$ = FALSE;
else else
ereport(ERROR, ereport(ERROR,

2
src/test/subscription/t/001_rep_changes.pl
View File

@@ -179,7 +179,7 @@ $node_publisher->poll_query_until('postgres',
or die "Timed out while waiting for apply to restart"; or die "Timed out while waiting for apply to restart";
# check all the cleanup # check all the cleanup
$node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION tap_sub_renamed"); $node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION tap_sub_renamed DROP SLOT");
$result = $result =
$node_subscriber->safe_psql('postgres', "SELECT count(*) FROM pg_subscription"); $node_subscriber->safe_psql('postgres', "SELECT count(*) FROM pg_subscription");